Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for waiting indefinitely for an ip when deploying on ovirt 4.4 #121

Merged
merged 1 commit into from Jan 5, 2021

Conversation

daFritz84
Copy link

fix for issue #120

I'm by no means a ruby programmer, but this works for me. The old code tried to collect the ip addresses from the original nic object, not from the reported_devices. I guess, there was an ever so slight change in the ruby sdk or the API.

Tested with ovirt 4.4.2.6-1.el8 and ubuntu 20.04 WSL on Windows 10 20H2

@myoung34
Copy link
Owner

myoung34 commented Jan 4, 2021

I'm by no means a ruby programmer

Yeah you are, you just wrote ruby ;)

Would you be able to test CentOS also just to make sure its not some sort of accidental ubuntu-only fix?

Usually I'd test myself But i no longer have access to oVirt

@daFritz84
Copy link
Author

Test OK on CentOS 8.3 VM to virt 4.4.2.6-1.el8 cluster.

See log:
(Please ignore the 'Test' output befor GOT IP ..., it's just a quick'n'dirty modification of en.yaml to ensure my code is running and not the original plugin)

[root@SE-VMTEST vagrant-ovirt4]# vagrant up
==> default: Box 'ovirt4' could not be found. Attempting to find and install...
    default: Box Provider: ovirt4
    default: Box Version: >= 0
==> default: Box file was not detected as metadata. Adding it directly...
==> default: Adding box 'ovirt4' (v0) for provider: ovirt4
    default: Downloading: https://github.com/myoung34/vagrant-ovirt4/blob/master/example_box/dummy.box?raw=true
==> default: Successfully added box 'ovirt4' (v0) for 'ovirt4'!
Bringing machine 'default' up with 'ovirt4' provider...
==> default: Creating VM with the following settings...
==> default:  -- Name:          centos-dev
==> default:  -- Cluster:       Intel_Cluster
==> default:  -- Template:      centos-8
==> default:  -- Console Type:  spice
==> default:  -- BIOS Serial:
==> default:  -- Optimized For:
==> default:  -- Description:
==> default:  -- Comment:
==> default:  -- Memory:
==> default:  ---- Memory:      768 MB
==> default:  ---- Maximum:     768 MB
==> default:  ---- Guaranteed:  768 MB
==> default:  -- Cpu:
==> default:  ---- Cores:       1
==> default:  ---- Sockets:     1
==> default:  ---- Threads:     2
==> default:  -- Cloud-Init:    true
==> default: Waiting for VM to become "ready" to start...
==> default: Starting VM.
==> default: Test
==> default: Got IP: 10.20.190.23
==> default: Got IP: 10.20.190.23
==> default: Got IP: 10.20.190.23
==> default: Got IP: 10.20.190.23
==> default: Got IP: 10.20.190.23
==> default: Got IP: 10.20.190.23
==> default: Got IP: 10.20.190.23
==> default: Got IP: 10.20.190.23
==> default: Got IP: 10.20.190.23
==> default: Machine is booted and ready for use!
==> default: Rsyncing folder: /root/vagrant-ovirt4/ => /vagrant
SSH authentication failed! This is typically caused by the public/private
keypair for the SSH user not being properly set on the guest VM. Please
verify that the guest VM is setup with the proper public key, and that
the private key path for Vagrant is setup properly as well.

@myoung34
Copy link
Owner

myoung34 commented Jan 5, 2021

🎉

@myoung34 myoung34 merged commit 23b130f into myoung34:master Jan 5, 2021
@daFritz84 daFritz84 deleted the fix-waiting-for-ip branch January 5, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants